Explore: PHP CORS Proxy #1546
Draft
Explore: PHP CORS Proxy #1546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Work in progress. To integrate [git clone](https://adamadam.blog/2024/06/21/cloning-a-git-repository-from-a-web-browser-using-fetch/) via `fetch()`, we need a CORS proxy. This PR explores an implementation. Assumptions: * It will run on a separate hostname – ideally not even a subdomain * No auth headers should make it through either way * No requests to private IPs * Stream data both ways, don't buffer Remaining work: * For now, refuse to process non-GET non-POST non-OPTIONS requests * Refuse to process POST request body larger than, say, 100KB * Refuse to process responses larger than, say, 100MB * Smart rate limiting * Support for query args * More unit tests See #1467
28 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work in progress.
To integrate git clone via
fetch(), we need a CORS proxy. This PR explores an implementation.Assumptions:
Remaining work:
Testing instructions
dev.shto start a local server, then go tohttp://127.0.0.1:5263/proxy.php/https://w.org/and confirm it worked.test.shto run PHPUnit tests, confirm they all pass.See #1467