-
Notifications
You must be signed in to change notification settings - Fork 374
[ xdebug ] Add --experimental-unsafe-ide-integration option in PHP.wasm CLI
#2947
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 3 commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| { | ||
| "extends": ["../../../.eslintrc.json"], | ||
| "ignorePatterns": ["!**/*"], | ||
| "overrides": [ | ||
| { | ||
| "files": ["*.ts", "*.tsx", "*.js", "*.jsx"], | ||
| "rules": {} | ||
| }, | ||
| { | ||
| "files": ["*.ts", "*.tsx"], | ||
| "rules": {} | ||
| }, | ||
| { | ||
| "files": ["*.js", "*.jsx"], | ||
| "rules": {} | ||
| } | ||
| ] | ||
| } |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| # php-wasm-cli-util | ||
|
|
||
| This library was generated with [Nx](https://nx.dev). | ||
|
|
||
| ## Building | ||
|
|
||
| Run `nx build php-wasm-cli-util` to build the library. | ||
|
|
||
| ## Running unit tests | ||
|
|
||
| Run `nx test php-wasm-cli-util` to execute the unit tests via [Vitest](https://vitest.dev). |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,46 @@ | ||
| { | ||
| "name": "@php-wasm/cli-util", | ||
| "version": "3.0.22", | ||
| "description": "Utilities for PHP.wasm related CLIs", | ||
| "repository": { | ||
| "type": "git", | ||
| "url": "https://github.com/WordPress/wordpress-playground" | ||
| }, | ||
| "homepage": "https://developer.wordpress.org/playground", | ||
| "author": "The WordPress contributors", | ||
| "contributors": [ | ||
| { | ||
| "name": "Adam Zielinski", | ||
|
||
| "email": "[email protected]", | ||
| "url": "https://github.com/adamziel" | ||
| } | ||
| ], | ||
| "exports": { | ||
| ".": { | ||
| "import": "./index.js", | ||
| "require": "./index.cjs" | ||
| }, | ||
| "./package.json": "./package.json", | ||
| "./README.md": "./README.md" | ||
| }, | ||
| "main": "./index.cjs", | ||
| "module": "./index.js", | ||
| "type": "module", | ||
| "types": "index.d.ts", | ||
| "typedoc": { | ||
| "entryPoint": "./src/index.ts", | ||
| "readmeFile": "./README.md", | ||
| "displayName": "@php-wasm/cli-util", | ||
| "tsconfig": "./tsconfig.lib.json" | ||
| }, | ||
| "publishConfig": { | ||
| "access": "public", | ||
| "directory": "../../../dist/packages/php-wasm/cli-util" | ||
| }, | ||
| "license": "GPL-2.0-or-later", | ||
| "gitHead": "2f8d8f3cea548fbd75111e8659a92f601cddc593", | ||
| "engines": { | ||
| "node": ">=20.18.3", | ||
| "npm": ">=10.1.0" | ||
| } | ||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,81 @@ | ||
| { | ||
| "name": "php-wasm-cli-util", | ||
| "$schema": "../../../node_modules/nx/schemas/project-schema.json", | ||
| "sourceRoot": "packages/php-wasm/cli-util/src", | ||
| "projectType": "library", | ||
| "targets": { | ||
| "build": { | ||
| "executor": "nx:noop", | ||
| "dependsOn": ["build:README"] | ||
| }, | ||
| "build:README": { | ||
| "executor": "nx:run-commands", | ||
| "options": { | ||
| "commands": [ | ||
| "cp packages/php-wasm/cli-util/README.md dist/packages/php-wasm/cli-util" | ||
| ] | ||
| }, | ||
| "dependsOn": ["build:package-json"] | ||
| }, | ||
| "build:package-json": { | ||
| "executor": "@wp-playground/nx-extensions:package-json", | ||
| "options": { | ||
| "tsConfig": "packages/php-wasm/cli-util/tsconfig.lib.json", | ||
| "outputPath": "dist/packages/php-wasm/cli-util", | ||
| "buildTarget": "php-wasm-cli-util:build:bundle:production" | ||
| } | ||
| }, | ||
| "build:bundle": { | ||
| "executor": "@nx/vite:build", | ||
| "outputs": ["{options.outputPath}"], | ||
| "options": { | ||
| "emptyOutDir": false, | ||
| "outputPath": "dist/packages/php-wasm/cli-util" | ||
| } | ||
| }, | ||
| "publish": { | ||
| "executor": "nx:run-commands", | ||
| "options": { | ||
| "command": "node tools/scripts/publish.mjs php-wasm-cli-util {args.ver} {args.tag}" | ||
| }, | ||
| "dependsOn": ["build"] | ||
| }, | ||
| "package-for-self-hosting": { | ||
| "executor": "@wp-playground/nx-extensions:package-for-self-hosting", | ||
| "dependsOn": ["build"] | ||
| }, | ||
| "lint": { | ||
| "executor": "@nx/linter:eslint", | ||
| "outputs": ["{options.outputFile}"], | ||
| "options": { | ||
| "useFlatConfig": false, | ||
| "lintFilePatterns": ["packages/php-wasm/cli-util/**/*.ts"], | ||
| "maxWarnings": 0 | ||
| } | ||
| }, | ||
| "test": { | ||
| "executor": "@nx/vite:test", | ||
| "outputs": ["{workspaceRoot}/coverage/packages/php-wasm/cli-util"], | ||
| "options": { | ||
| "reportsDirectory": "../../../coverage/packages/php-wasm/cli-util" | ||
| } | ||
| }, | ||
| "test:esmcjs": { | ||
| "executor": "@wp-playground/nx-extensions:assert-built-esm-and-cjs", | ||
| "options": { | ||
| "outputPath": "dist/packages/php-wasm/cli-util" | ||
| }, | ||
| "dependsOn": ["build"] | ||
| }, | ||
| "typecheck": { | ||
| "executor": "nx:run-commands", | ||
| "options": { | ||
| "commands": [ | ||
| "tsc -p packages/php-wasm/cli-util/tsconfig.lib.json --noEmit", | ||
| "tsc -p packages/php-wasm/cli-util/tsconfig.spec.json --noEmit" | ||
| ] | ||
| } | ||
| } | ||
| }, | ||
| "tags": ["scope:independent-from-php-binaries"] | ||
| } |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| export * from './lib'; |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| export * from './mounts'; | ||
| export * from './xdebug-path-mappings'; |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| export interface Mount { | ||
| hostPath: string; | ||
| vfsPath: string; | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nitpick:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is already a
utildirectory inphp-wasmso to keep consistency I named the packagephp-wasm/cli-utilwithout thes. What should I do?I guess renaming
php-wasm/utilinphp-wasm/utilswill be more trouble than it’s worth, right?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I see. Yeah, we're good then