[ Vite ] Regroup preserve-*-loaders-imports Vite plugin inside a vite-extension
#3002
+163
−130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamziel
reviewed
Dec 9, 2025
adamziel
reviewed
Dec 9, 2025
adamziel
reviewed
Dec 9, 2025
adamziel
reviewed
Dec 9, 2025
mho22
force-pushed
the
create-vite-preserve-loaders-imports
branch
from
bec8e01 to
921dfb0
Compare
adamziel
reviewed
Dec 9, 2025
Collaborator
|
I took a pass over the comments, LMK if they're accurate @mho22 |
Collaborator
Author
|
@adamziel LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for the change, related issues
Based on #2999
Intl dynamic extension added a third file where its import had to be ignored : icu.dat. The pull request created a third
preserve-data-loaders-importsVite plugin. This pull request aims to regroup every preserve-{extension}-loaders-imports into a unique Vite extension.This pull request is more a suggestion than its
ignore-*-importscounterpart.Implementation details
Regrouping repeatedly copy pasted vite plugins inside a vite extension file named `vite-preserve-loaders-imports.ts.
Testing Instructions
CI -
test-built-npm-packagesshould not fail