Add CI test for multi-worker concurrent request handling #3014
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a test suite that verifies the CLI correctly distributes concurrent HTTP requests across multiple workers. The tests send parallel requests to PHP scripts that return their process ID, then confirm each request was handled by a different worker. This catches regressions in the load balancer and worker spawning logic.
adamziel
added
[Type] Enhancement
The CLI tests were failing on CI due to a race condition when multiple test files try to download WordPress concurrently. When tests ran in parallel, multiple processes competed for the same download file, causing ENOENT errors when one process's partial file was overwritten by another. This adds fileParallelism: false to the vitest config to run test files sequentially, avoiding the download race condition.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds a test suite that verifies the CLI correctly distributes concurrent HTTP requests across multiple workers. The tests send parallel requests to PHP scripts that respond with a HTTP header containing their process ID. Then the test confirms each request was handled by a different worker.
This catches regressions in the load balancer and worker spawning logic.
Test plan
test-playground-clijobmulti-worker-requests.spec.tsrun and pass