Be consistent in how we're generating string interpolations

[alanknight-wk]

Motivation

If we use toSource() on a node that's an interpolation, we usually (unless it would be ambiguous?) get
"stuff $variable more stuff"
But we are careful to always emit interpolations as
"stuff ${variable} more stuff"

When we are checking to see if a message already exists by a name, we compare the messageText. But if it's an interpolation, we were generating it via toSource(), which wouldn't agree. So be consistent in how we're generating it.

Note that this can leave us generating two different messages for the two different forms if there was an existing version that was generated before we started using curly braces. But that can be future work on de-duplication.

Changes

Release Notes

Review

See CONTRIBUTING.md for more details on review types (+1 / QA +1 / +10) and code review process.

Please review:

QA Checklist

• Tests were updated and provide good coverage of the changeset and other affected code
• Manual testing was performed if needed
  • Steps from PR author:
  • Anything falling under manual testing criteria outlined in CONTRIBUTING.md

Merge Checklist

While we perform many automated checks before auto-merging, some manual checks are needed:

• A Frontend Frameworks Design member has reviewed these changes
• There are no unaddressed comments - this check can be automated if reviewers use the "Request Changes" feature
• For release PRs - Version metadata in Rosie comment is correct

[aviary3-wk]

Security Insights

No security relevant content was detected by automated scans.

Action Items

• Review PR for security impact; comment "security review required" if needed or unsure
• Verify aviary.yaml coverage of security relevant code

---

Questions or Comments? Reach out on Slack: #support-infosec.