Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DSC-9978 - Complete transition to GHA #46

Merged
merged 5 commits into from
Apr 4, 2024
Merged

DSC-9978 - Complete transition to GHA #46

merged 5 commits into from
Apr 4, 2024

Conversation

nickshoust-wf
Copy link
Member

@nickshoust-wf nickshoust-wf commented Apr 4, 2024 •
edited
Loading

Summary

Finish migration to GHA.

  • Remove Dockerfile
  • Remove skynet.yaml
  • Generate an SBOM

Testing

  • CI passing
  • cyclone DX file attached as an artifact on the GHA build

following this internal guide

@aviary-wf
Copy link

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

@nickshoust-wf
Copy link
Member Author

QA +1
https://github.com/Workiva/test_html_builder/actions/runs/8555898577?pr=46
Screenshot 2024-04-04 at 10 01 55 AM

robbecker-wf
robbecker-wf approved these changes Apr 4, 2024
View reviewed changes
Copy link
Member

@robbecker-wf robbecker-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+10 cyclone file attached, required GHA set

@robbecker-wf
Copy link
Member

@Workiva/release-management-p

rmconsole-wf
rmconsole-wf approved these changes Apr 4, 2024
View reviewed changes
Copy link

@rmconsole-wf rmconsole-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 from RM

@rmconsole4-wk rmconsole4-wk merged commit e89a6a3 into master Apr 4, 2024
9 checks passed
@rmconsole4-wk rmconsole4-wk deleted the gha-sbom branch April 4, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmconsole-wf rmconsole-wf rmconsole-wf approved these changes

@robbecker-wf robbecker-wf robbecker-wf approved these changes

Assignees
No one assigned
Labels
RM Ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nickshoust-wf @aviary-wf @robbecker-wf @rmconsole-wf @rmconsole4-wk