Serialize settings for size attributes #345
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Serialization of size attributes currently doesn't work. We have a special column name (
SIZE_COLUMN_NAME
) designated for storing sizes in the serialization, but that column name is never actually used in the layer's data table. This PR updates the serialized state to match the settings messages that are dispatched here.I'm not sure how often serialization is used, but one intended use case would be glue-viz/glue-wwt#62, as using size attributes is a common operation in glue.