-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
package.json: require newest engine to get better touch gesture handling #72
Conversation
Build error here seems to have something to do with the latest version of Node.js. I'll try to dig into it a bit. |
Writing down some more info about the error since this is looking like it will take some time to figure out. The proximate error is during our
(There's also a lot of noise about This has to do with fp-ts. It appears to be some issue related to CJS vs. MJS modules, and fp-ts (and the related io-ts) do package themselves in a somewhat unusual way regarding this. This problem is also manifesting itself only with newer versions of Node.js. I see it with 20.11.0, but not with 18.12.1. We use fp-ts and io-ts in the import { isLeft } from "fp-ts/lib/Either.js";
import * as t from "io-ts";
import { PathReporter } from "io-ts/lib/PathReporter.js"; These imports are for older-style CJS files. If I change them to explicitly point to the ES6 versions, the
And more importantly, the
Both of these import syntaxes for fp/io-ts are discouraged. Instead we're supposed to use:
Unfortunately, this leads to the same |
So far gcanti/io-ts#688 contains the most helpful discussion that I've seen about these kinds of problems. There are some workarounds posted there, but it seems like it might be better to port to Effect. There don't seem to be official porting docs, but this blog post is a start. A port seems plausible since our use of fp/io-ts is fairly constrained and un-fancy. |
As hoped, this seems to fix our build issues. And the port is pretty straightforward; nearly doable with search-and-replace. Not yet extensively tested but it seems to be working ...
@Carifio24 OK, I've logged some information about the build error here, which I think I've solved by migrating from fp-ts/io-ts to Effect-ts. Would you have a chance to test out this branch a bit on your machine and help check whether everything seems to be working OK with the change? And that you can build it, etc. |
Edit: After a bit more testing, I think this was because my local Keycloak Docker instance wasn't running, so that's just a problem on my end. Looks all good now. |
Thanks for checking it out! Let's see how it goes. |
Also a general update of deps.