Have opacity set annotation batch as dirty #259
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on glue-viz/glue-wwt#96, I noticed some issues with changing the opacity of the line, even though we added support for annotation opacity in #238. Since the opacity would update when other properties were changed, I realized that the issue is that we don't mark the annotation batch as dirty when opacity is updated. This means that opacity updates are only realized after another property that does mark the batch as dirty has been changed. This PR remedies this by marking the batch as dirty when the opacity has changed.
Do we also want to do the same thing for the
Label
andShowHoverLabel
properties? It seems like we would, but I don't know enough about what these are used for.