Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Sunreaver Micro-Sentry to the database (as well as the UiMapID for Isle of Thunder) #676

Merged
merged 1 commit into from
Oct 31, 2023
Merged

Add Sunreaver Micro-Sentry to the database (as well as the UiMapID for Isle of Thunder) #676

merged 1 commit into from
Oct 31, 2023

Conversation

cyriun
Copy link
Contributor

@cyriun cyriun commented Oct 31, 2023

No description provided.

@cyriun
Copy link
Contributor Author

cyriun commented Oct 31, 2023

from #675

@rdw-software rdw-software changed the title addition of sunreaver pet to db and optional uimapid for coords Add Sunreaver Micro-Sentry to the database (as well as the UiMapID for Isle of Thunder) Oct 31, 2023
@rdw-software rdw-software merged commit a05e263 into WowRarity:master Oct 31, 2023
5 checks passed
@rdw-software
Copy link
Member

Thanks! It looks like you forgot to actually make use of the UiMapID for Isle of Thunder, so I've made the necessary changes.

@rdw-software rdw-software mentioned this pull request Oct 31, 2023
Closed
@cyriun
Copy link
Contributor Author

cyriun commented Oct 31, 2023

Thanks! It looks like you forgot to actually make use of the UiMapID for Isle of Thunder, so I've made the necessary changes.

rightt, haha, i copied same format as above but its using uimapid 554 which is timeless isle and not added into SharedConstants. Oops

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cyriun @rdw-software