Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve recognition of untranslated text #477

Merged
merged 6 commits into from
Aug 8, 2024

Conversation

pcm1k
Copy link
Contributor

@pcm1k pcm1k commented Oct 8, 2021

Make ChatTranslatorHack properly handle whitespace when comparing untranslated text, and translated text. Google Translate sometimes likes to insert, or delete whitespace randomly. So I think simply ignoring whitespace should be fine, and fix this issue.

Copy link

@theavgeekbee theavgeekbee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this properly handles whitespace, then it is very effective.

This comment was marked as outdated.

Copy link

coderabbitai bot commented Dec 12, 2023

Walkthrough

Walkthrough

The change involves an update to the comparison logic in the translate method of the GoogleTranslate.java file. The original simple case-insensitive comparison between the source and translated text has been enhanced to ignore white spaces. Now, before comparing, the method strips all white spaces from both the original and translated strings, ensuring a more robust equivalence check that is not affected by differences in spacing.

Changes

File Change Summary
.../util/GoogleTranslate.java Updated the translate method to ignore white spaces when comparing the original and translated text for case-insensitive equality.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@Alexander01998 Alexander01998 added type:bugfix This can be released as a patch. category:chat and removed status:stale labels Dec 12, 2023
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 2

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 2603857 and dc77245.
Files selected for processing (1)
  • src/main/java/net/wurstclient/util/GoogleTranslate.java (1 hunks)

src/main/java/net/wurstclient/util/GoogleTranslate.java Outdated Show resolved Hide resolved
src/main/java/net/wurstclient/util/GoogleTranslate.java Outdated Show resolved Hide resolved

This comment was marked as outdated.

This comment was marked as outdated.

@Alexander01998 Alexander01998 added status:never-stale Prevents stalebot from marking this item as stale. and removed status:stale labels Apr 17, 2024
@Alexander01998 Alexander01998 added this to the v7.45 milestone Jul 18, 2024
@Alexander01998 Alexander01998 added the status:merged This pull request has been merged, even if GitHub says otherwise. label Jul 18, 2024
@Alexander01998 Alexander01998 merged commit feed9bc into Wurst-Imperium:master Aug 8, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:chat status:merged This pull request has been merged, even if GitHub says otherwise. status:never-stale Prevents stalebot from marking this item as stale. type:bugfix This can be released as a patch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants