Fixed AttributeError when exporting object with draped normal map decal 1 set #745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Fixed objects failing to export when draped normal map decal 1 is set. This fixes the issue "Draped normal map decal 1 causes objects to fail to export #744"
Detailed changes:
Line 765 of xplane_header was attempting to access
self.xplaneFile.draped_normal_decal1_projected, howeverdraped_normal_decal1_projectedexists inxplaneFile.options, not directly inxplaneFile.This pull request changes line xplane_header 765 to properly access
self.xplaneFile.options.draped_normal_decal1_projectedinstead. This is consistent with the rest of the decal code.Testing:
No unit tests were run, however I tested exporting objects with draped normal map decals, they exported correctly, and were loaded, and displayed correctly in sim.