Skip to content

Conversation

karl-sjogren
Copy link

This PR adds support for the new XML-based solution format for Visual Studio, which is just XML with another extension.

For more info: https://devblogs.microsoft.com/dotnet/introducing-slnx-support-dotnet-cli/

languages.json Outdated
@@ -1946,6 +1946,12 @@
"blank": true,
"extensions": ["sln"]
},
"VisualStudioSolutionSlnx": {
"name": "Visual Studio Solution",
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what happens if you run this in a folder with both a .sln and .slnx file in the same directory structure. Should this one maybe have a name such as "Visual Studio Solution (slnx)"?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR! I believe it will just show two rows with the same name. I think having something to distinguish it like what you mentioned would be a good idea.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have updated the name to "Visual Studio Solution (slnx)".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants