765: odk:client-editable submission config#766
Merged
Conversation
- similar to auto_send / auto_delete, but requested to allow more true/false-y values than just 'true' accepted for those.
lindsay-stevens
changed the title
lognaturel
approved these changes
Jun 3, 2025
lognaturel
left a comment
lognaturel
left a comment
Contributor
There was a problem hiding this comment.
Wonderful, thank you!
As much as I don't love aliases, I think it's helpful to be consistent in what's supported for true/false values across the survey and settings sheets. I'll file an issue to also support aliases for auto_delete and auto_send
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #765
Why is this the best possible solution? Were any other approaches considered?
Similar to auto_send / auto_delete, but requested to allow more true/false-y values than just 'true' accepted for those.
What are the regression risks?
Unlikely problem but if a user had a setting column called 'client-editable' used for something else like documentation, now it does something to the XForm if it contains an alias of
true.Does this change require updates to documentation? If so, please file an issue here and include the link below.
Filed getodk/xforms-spec#328 and getodk/docs#1957
Before submitting this PR, please make sure you have:
testspython -m unittestand verified all tests passruff format pyxform testsandruff check pyxform teststo lint code