Skip to content

Update dependencies#774

Merged
lindsay-stevens merged 3 commits into
XLSForm:masterfrom
lindsay-stevens:update-deps
Jul 21, 2025
Merged

Update dependencies#774
lindsay-stevens merged 3 commits into
XLSForm:masterfrom
lindsay-stevens:update-deps

Conversation

@lindsay-stevens

Copy link
Copy Markdown
Contributor

Why is this the best possible solution? Were any other approaches considered?

Last update >6 months ago. Did not update to xlrd==2.0.2 since the change there seemed like it might be dubious or unnecessary (added new XLS binary test file, no changes to the project for 4 years before that, and the change relates to formula handling which probably isn't relevant to pyxform, probably about time to deprecate XLS anyway). Updated the default dev version from py3.10 to py3.12 to match pyodk - the supported range remains py3.10 thru 3.13.

Also applied new or updated ruff linter rules: sort slot names, use dict.fromkeys instead of k: None comps, collapse adjacent strings, update % string formats to f-strings, etc.

What are the regression risks?

Library users that have dependencies conflicting with the new pinned versions - more so openpyxl than the dev deps.

Does this change require updates to documentation? If so, please file an issue here and include the link below.

No, but the readme was updated.

Before submitting this PR, please make sure you have:

  • included test cases for core behavior and edge cases in tests
  • run python -m unittest and verified all tests pass
  • run ruff format pyxform tests and ruff check pyxform tests to lint code
  • verified that any code or assets from external sources are properly credited in comments

- for consistency with pyodk
- remove S320 ignore since the rule was deleted
@lindsay-stevens lindsay-stevens merged commit e399e76 into XLSForm:master Jul 21, 2025
13 checks passed
@lindsay-stevens lindsay-stevens deleted the update-deps branch July 21, 2025 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants