Update dependencies#774
Merged
Merged
Conversation
- for consistency with pyodk
- remove S320 ignore since the rule was deleted
lognaturel
approved these changes
Jul 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why is this the best possible solution? Were any other approaches considered?
Last update >6 months ago. Did not update to
xlrd==2.0.2since the change there seemed like it might be dubious or unnecessary (added new XLS binary test file, no changes to the project for 4 years before that, and the change relates to formula handling which probably isn't relevant to pyxform, probably about time to deprecate XLS anyway). Updated the default dev version from py3.10 to py3.12 to match pyodk - the supported range remains py3.10 thru 3.13.Also applied new or updated ruff linter rules: sort slot names, use dict.fromkeys instead of
k: Nonecomps, collapse adjacent strings, update%string formats to f-strings, etc.What are the regression risks?
Library users that have dependencies conflicting with the new pinned versions - more so openpyxl than the dev deps.
Does this change require updates to documentation? If so, please file an issue here and include the link below.
No, but the readme was updated.
Before submitting this PR, please make sure you have:
testspython -m unittestand verified all tests passruff format pyxform testsandruff check pyxform teststo lint code