Update faucet_url processing logic #690
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
This PR seeks to address #364
This is an alternative approach competing with #676
PR #676 needs to be closed after this PR is reviewed and merged.
Context of Change
Type of Change
Did you update CHANGELOG.md?
This PR improves the handling of the faucet URL. I'm not sure if it needs to be included in the CHANGELOG. The changes are intuitive.
Test Plan
Some unit tests have been added to validate this change.
Many thanks to @justinr1234 for coming up with the design and code for this solution