Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update faucet_url processing logic #690

Merged
merged 2 commits into from
Mar 20, 2024
Merged

Update faucet_url processing logic #690

merged 2 commits into from
Mar 20, 2024

Conversation

ckeshava
Copy link
Collaborator

High Level Overview of Change

This PR seeks to address #364

This is an alternative approach competing with #676
PR #676 needs to be closed after this PR is reviewed and merged.

Context of Change

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Tests (You added tests for code that already exists, or your new feature included in this PR)
  • Documentation Updates
  • Release

Did you update CHANGELOG.md?

  • Yes
  • No, this change does not impact library users
    This PR improves the handling of the faucet URL. I'm not sure if it needs to be included in the CHANGELOG. The changes are intuitive.

Test Plan

Some unit tests have been added to validate this change.

Many thanks to @justinr1234 for coming up with the design and code for this solution

Copy link
Contributor

@jonathanlei jonathanlei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

@jonathanlei
Copy link
Contributor

LGTM

@ckeshava ckeshava merged commit 5548b55 into main Mar 20, 2024
21 checks passed
@ckeshava ckeshava deleted the justinURL branch March 20, 2024 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants