Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add input check for OracleSet params AssetPrice and Scale #711

Merged
merged 2 commits into from
May 30, 2024
Merged

feat: add input check for OracleSet params AssetPrice and Scale #711

merged 2 commits into from
May 30, 2024

Conversation

anissa-ripple
Copy link
Collaborator

High Level Overview of Change

Context of Change

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Tests (You added tests for code that already exists, or your new feature included in this PR)
  • Documentation Updates
  • Release

Did you update CHANGELOG.md?

  • Yes
  • No, this change does not impact library users

Test Plan

@anissa-ripple
Copy link
Collaborator Author

I removed the nested model validation since that is covered by @mvadari 's PR here #708

@anissa-ripple anissa-ripple merged commit 9c09eef into main May 30, 2024
21 checks passed
@anissa-ripple anissa-ripple deleted the DGE-3199 branch May 30, 2024 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khancode khancode khancode approved these changes

@justinr1234 justinr1234 justinr1234 approved these changes

@pdp2121 pdp2121 Awaiting requested review from pdp2121

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anissa-ripple @justinr1234 @khancode