Webhooks list API newline handling (#2287) #2340
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Allow for escaped newlines inside double quoted blocks in payload when pulling the list of webhooks from the webhooks API * Unit tests for newlines inside and outside quoted JSON strings in payload
|
@dotnet-policy-service agree |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Escaped new lines are allowed in the quoted JSON strings in payload for webhooks, but fail to render in the HealthChecks UI interface. An exception is thrown when Regex.Unescape() is called and then JsonNode.Parse() on the results, and literal newlines are included in JSON strings of the payload.
Which issue(s) this PR fixes:
Please reference the issue this PR will close: #2287
Special notes for your reviewer:
First time contributing to a open source github project, this submission may be rough. I do not know how to run end-to-end tests.
Does this PR introduce a user-facing change?:
Yes
Please make sure you've completed the relevant tasks for this PR, out of the following list: