-
Notifications
You must be signed in to change notification settings - Fork 804
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate HealthChecks.SqlServer tests to Testcontainers #2348
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall it looks great, but it would be nice if we could simplify the yml file and reuse the pattern in other PRs (so introducing changes in the future like updating to .NET 10 requires even fewer changes).
Thank you @Alirexaa !
@@ -30,14 +30,6 @@ on: | |||
jobs: | |||
build: | |||
runs-on: ubuntu-latest | |||
services: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seeing this change made me realize that we now may be able to do some yaml refactoring and reuse the https://github.com/Xabaril/AspNetCore.Diagnostics.HealthChecks/blob/master/.github/workflows/reusable_ci_workflow.yml file.
The jobs part for this file could be just:
jobs:
build:
uses: ./.github/workflows/reusable_ci_workflow.yml
with:
PROJECT_PATH: ./src/HealthChecks.SqlServer/HealthChecks.SqlServer.csproj
TEST_PROJECT_PATH: ./test/HealthChecks.SqlServer.Tests/HealthChecks.SqlServer.Tests.csproj
CODECOV_FLAGS: SqlServer
(I took the example from
AspNetCore.Diagnostics.HealthChecks/.github/workflows/healthchecks_cosmosdb_ci.yml
Lines 30 to 36 in f54852f
jobs: | |
build: | |
uses: ./.github/workflows/reusable_ci_workflow.yml | |
with: | |
PROJECT_PATH: ./src/HealthChecks.CosmosDb/HealthChecks.CosmosDb.csproj | |
TEST_PROJECT_PATH: ./test/HealthChecks.CosmosDb.Tests/HealthChecks.CosmosDb.Tests.csproj | |
CODECOV_FLAGS: CosmosDb |
What this PR does / why we need it:
Which issue(s) this PR fixes:
Contributes to #2335
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Please make sure you've completed the relevant tasks for this PR, out of the following list: