Skip to content

Sync: Ripple(d) 2.5.1 [DO NOT MERGE] #680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tequdev wants to merge 58 commits into
base: dev
Choose a base branch
from

Fix: Don't flag consensus as stalled prematurely (#5658)

cff528d
Select commit
Loading
Failed to load commit list.
Open

Sync: Ripple(d) 2.5.1 [DO NOT MERGE] #680

Fix: Don't flag consensus as stalled prematurely (#5658)
cff528d
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded May 7, 2026 in 1s

67.20% (target 60.00%)

View this Pull Request on Codecov

67.20% (target 60.00%)

Details

Codecov Report

❌ Patch coverage is 80.76063% with 258 lines in your changes missing coverage. Please review.
✅ Project coverage is 67.20%. Comparing base (9b50b68) to head (cff528d).

Files with missing lines Patch % Lines
include/xrpl/basics/IntrusivePointer.ipp 75.26% 41 Missing and 28 partials ⚠️
include/xrpl/basics/TaggedCache.ipp 79.46% 36 Missing and 18 partials ⚠️
include/xrpl/basics/SharedWeakCachePointer.ipp 59.25% 13 Missing and 9 partials ⚠️
include/xrpl/basics/IntrusiveRefCounts.h 78.35% 8 Missing and 13 partials ⚠️
src/libxrpl/protocol/STTx.cpp 80.39% 10 Missing and 10 partials ⚠️
src/libxrpl/protocol/Permissions.cpp 82.92% 2 Missing and 5 partials ⚠️
src/libxrpl/protocol/STAmount.cpp 61.11% 2 Missing and 5 partials ⚠️
include/xrpl/server/detail/UDPDoor.h 0.00% 5 Missing ⚠️
src/libxrpl/json/json_valueiterator.cpp 61.53% 5 Missing ⚠️
src/libxrpl/protocol/STNumber.cpp 85.29% 1 Missing and 4 partials ⚠️
... and 29 more
Additional details and impacted files 
@@            Coverage Diff             @@
##              dev     #680      +/-   ##
==========================================
+ Coverage   66.57%   67.20%   +0.63%     
==========================================
  Files         837      864      +27     
  Lines       78540    81373    +2833     
  Branches    44600    46287    +1687     
==========================================
+ Hits        52288    54687    +2399     
- Misses      17859    17988     +129     
- Partials     8393     8698     +305

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
View more details on Codecov