Skip to content

fix: Replace badCurrency() checks with isBadCurrency() for improved clarity#742

Open
tequdev wants to merge 1 commit intoXahau:devfrom
tequdev:fix-badcurrency
Open

fix: Replace badCurrency() checks with isBadCurrency() for improved clarity#742
tequdev wants to merge 1 commit intoXahau:devfrom
tequdev:fix-badcurrency

Conversation

@tequdev
Copy link
Copy Markdown
Member

@tequdev tequdev commented May 7, 2026

High Level Overview of Change

Context of Change

Type of Change

  • Bug fix (non-breaking change which fixes an issue)

API Impact

  • Public API: New feature (new methods and/or new fields)
  • Public API: Breaking change (in general, breaking changes should only impact the next api_version)
  • libxrpl change (any change that may affect libxrpl or dependents of libxrpl)
  • Peer protocol change (must be backward compatible or bump the peer protocol version)

@codecov
Copy link
Copy Markdown

codecov Bot commented May 7, 2026

Codecov Report

❌ Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 66.58%. Comparing base (9b50b68) to head (a272926).

Files with missing lines Patch % Lines
src/libxrpl/protocol/Issue.cpp 0.00% 0 Missing and 1 partial ⚠️
src/libxrpl/protocol/STCurrency.cpp 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #742   +/-   ##
=======================================
  Coverage   66.57%   66.58%           
=======================================
  Files         837      837           
  Lines       78540    78540           
  Branches    44600    44600           
=======================================
+ Hits        52288    52292    +4     
+ Misses      17859    17853    -6     
- Partials     8393     8395    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant