ON-15512: Don't fail with non cri-o container runtime #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pcolledg-amd
approved these changes
Jan 11, 2024
|
Please update "Supported environment" README section to list known compatibility. |
ivatet-amd
approved these changes
Jan 11, 2024
Any container runtime that is compatible with the cri should work fine since we are using `crictl` which is designed to run against the standard.
tcrawley-xilinx
force-pushed
the
reviews/tcrawley/ON-15512
branch
from
23604d0 to
0edd38d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Any container runtime that is compatible with the cri should work fine since we are using
crictlwhich is designed to run against the standard.Testing done
Ran in-cluster, as expected no warning message.