-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ON-15464: Troubleshooting guide #123
Conversation
docs/troubleshooting.md
Outdated
* The version of Onload compiled in the `onload-user` images and the kernel modules compiled in-cluster or out of | ||
cluster from `onload-source` image match the standard Linux packages and are not customised variants. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't really understand what this is trying to say,
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Onload Operator v2.0 introduced a third variant of Onload: OpenOnload, EnterpriseOnload, and CloudOnload. In v3.0 we do not have such a variant and Onload's internals do not have Kubernetes- or container-related conditionals that may vary its performance. I'm open to a more precise rewording suggestion (provided it doesn't dredge up the history).
* sfnettest example now uses latency profile by default rather than recommended * Removed trailing slash on `$REGISTRY_BASE` causing invalid duplicate slashes * Added built-in syntax validation to user-modifiable commands * Documented containers of Onload Device Plugin pod * Updated README to reflect recent `setPreload` changes * Symlinks to existing docs in `docs/`
e6d9d30
to
f4da685
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated with Thomas' clarifications + minor linter.
docs/troubleshooting.md
Outdated
* The version of Onload compiled in the `onload-user` images and the kernel modules compiled in-cluster or out of | ||
cluster from `onload-source` image match the standard Linux packages and are not customised variants. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Onload Operator v2.0 introduced a third variant of Onload: OpenOnload, EnterpriseOnload, and CloudOnload. In v3.0 we do not have such a variant and Onload's internals do not have Kubernetes- or container-related conditionals that may vary its performance. I'm open to a more precise rewording suggestion (provided it doesn't dredge up the history).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates
Preview this PR's Troubleshooting Guide
$REGISTRY_BASE
causing duplicate slashes which is invalid in docker container image pathssetPreload
changesdocs/
(May further refine 'Modules and devices already loaded or mounted' and 'Day 0/1 MachineConfig' troubleshooting sections.)