Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SWUTILS-931: Add backup alternatives for depreciated Linux utilities #25

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dchadwic-xilinx
Copy link
Collaborator

This patch adds a backup in the case netstat, ifconfig, arp and/or route are not available. These utils are being depreciated and will be not be automatically installed in future Linux OS releases.

I have tested this on my systems but I would like to get hold of the newest RHEL 9.X or candidate 10 to test.

@ibeecraft-amd
Copy link
Contributor

My preference is to change the order to pull in the newer commands by default and revert to the older commands if required (on systems with ip for example). Others may prefer the formatting of the older ones but if these commands are scheduled to be removed from future RHEL we should get used to their output.

Scripts for parsing parts of the sfreport may require updates however.

@amitgu-xilinx
Copy link
Collaborator

"ip route show" and "ip -s -d addr show" commands are already used in sfreport. So might not be required to be reported twice.

@amitgu-xilinx
Copy link
Collaborator

Also worth updating the headline from "ifconfig" to more generic e.g" Network Configuration"

@amitgu-xilinx
Copy link
Collaborator

Might be worth reporting both outputs. So some people prefer old and other new commands

@dchadwic-xilinx
Copy link
Collaborator Author

@amitgu-xilinx @ibeecraft-amd

My preference is to change the order to pull in the newer commands by default and revert to the older commands if required (on systems with ip for example). Others may prefer the formatting of the older ones but if these commands are scheduled to be removed from future RHEL we should get used to their output.

Agree with this. The new commands now appear first.

"ip route show" and "ip -s -d addr show" commands are already used in sfreport. So might not be required to be reported twice.

Addressed this by removing the repeats of ip -4/-6 route show.

Might be worth reporting both outputs. So some people prefer old and other new commands

I have addressed this by keeping both outputs. However, in the case the new output is available the old output is hidden by default. The reason for this is to reduce the increased scrolling time.

@amitgu-xilinx
Copy link
Collaborator

amitgu-xilinx commented Sep 26, 2024 via email

@dchadwic-xilinx
Copy link
Collaborator Author

dchadwic-xilinx commented Sep 26, 2024

Jay’s sfreport reports still rely on the old data, so until he has a fix for this, we should keep the output visible. Or discuss with Jay.

I assume the miner uses the raw html in which case I would guess the lines being visible in the HTML viewer doesn't matter.
@jjay-xilinx any comment?

@jjay-xilinx
Copy link

jjay-xilinx commented Sep 26, 2024

I assume the miner uses the raw html in which case I would guess the lines being visible in the HTML viewer doesn't matter.

Correct.

It'll be a while before my miner encounters a customer sfreport in this new format, so plenty of time for me to fix and work around it.

@dchadwic-xilinx dchadwic-xilinx requested a review from a team September 26, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants