-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SWUTILS-931: Add backup alternatives for depreciated Linux utilities #25
base: main
Are you sure you want to change the base?
Conversation
My preference is to change the order to pull in the newer commands by default and revert to the older commands if required (on systems with ip for example). Others may prefer the formatting of the older ones but if these commands are scheduled to be removed from future RHEL we should get used to their output. Scripts for parsing parts of the sfreport may require updates however. |
"ip route show" and "ip -s -d addr show" commands are already used in sfreport. So might not be required to be reported twice. |
Also worth updating the headline from "ifconfig" to more generic e.g" Network Configuration" |
Might be worth reporting both outputs. So some people prefer old and other new commands |
525ba59
to
119b0ba
Compare
Agree with this. The new commands now appear first.
Addressed this by removing the repeats of
I have addressed this by keeping both outputs. However, in the case the new output is available the old output is hidden by default. The reason for this is to reduce the increased scrolling time. |
[AMD Official Use Only - AMD Internal Distribution Only]
@dchadwic-xilinx
I have addressed this by keeping both outputs. However, in the case the new output is available the old output is hidden by default. The reason for this is to reduce the increased scrolling time.
Jay’s sfreport reports still rely on the old data, so until he has a fix for this, we should keep the output visible. Or discuss with Jay.
|
I assume the miner uses the raw html in which case I would guess the lines being visible in the HTML viewer doesn't matter. |
Correct. It'll be a while before my miner encounters a customer sfreport in this new format, so plenty of time for me to fix and work around it. |
This patch adds a backup in the case
netstat
,ifconfig
,arp
and/orroute
are not available. These utils are being depreciated and will be not be automatically installed in future Linux OS releases.I have tested this on my systems but I would like to get hold of the newest RHEL 9.X or candidate 10 to test.