Rewrite unroute source/sink pin methods in DesignTools #575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eddie Hung <[email protected]>
Signed-off-by: Eddie Hung <[email protected]> Conflicts: src/com/xilinx/rapidwright/design/DesignTools.java
Signed-off-by: Eddie Hung <[email protected]>
Signed-off-by: Eddie Hung <[email protected]>
Signed-off-by: Eddie Hung <[email protected]>
eddieh-xlnx
force-pushed
the
rewrite_trimmable_pips
branch
from
cb31fe8 to
63e85a2
Compare
Unit Test Results 45 files 45 suites 12m 58s ⏱️ Results for commit a408c32. ♻️ This comment has been updated with latest results. |
Signed-off-by: Eddie Hung <[email protected]>
Signed-off-by: Eddie Hung <[email protected]>
Signed-off-by: Eddie Hung <[email protected]>
Signed-off-by: Eddie Hung <[email protected]>
eddieh-xlnx
changed the title
Signed-off-by: Eddie Hung <[email protected]>
eddieh-xlnx
force-pushed
the
rewrite_trimmable_pips
branch
from
644dedf to
b4407b3
Compare
clavin-xlnx
reviewed
Nov 10, 2022
This was referenced Nov 10, 2022
clavin-xlnx
approved these changes
Nov 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifically rewriting:
DesignTools.getTrimmablePIPsFromPins()and modifyingDesignTools.unrouteSourcePin().Also removes unused private method
DesignTools.unroutePin()Since it wasn't handling the two new testcases with bidirectional PIPs.
In this rewrite, use
PIP.isReversed()to get the correct driving/sink node.