Add config option to auto-start session with PAM #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows the user to choose whether to login automatically once PAM succeeds for the selected user. On one hand, automatic login makes using fingerprint login more pleasant -- the user does not need to also press the "Log In" button, once the fingerprint is recognized. On the other hand, using different PAM methods, autologin might be undesirable, as scrolling through the list of users might login a selected user when it is undesired. For this reason, having this functionality as a user-configurable setting makes sense.
|
Is it possible to split this into two settings, one for fingerprint logins and one for all other types of logins? Then set the default for normal logins to false and the default for fingerprint logins to true. |
|
Perhaps it could be possible, but one needs to look into whether the PAM API allows any disambiguation between fingerprint login and other logins. At the level of this change, this information is not directly available. What other types of logins do you have in mind? |
|
Seeing the same issue with using a Yubikey. Looking forward to this being implemented. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[This PR continues #107. All changes are now in a single commit, for easier review and merge.]
This allows the user to choose whether to login automatically once PAM succeeds for the selected user.
On one hand, automatic login makes using fingerprint login more pleasant -- the user does not need to also press the "Log In" button, once the fingerprint is recognized.
On the other hand, using different PAM methods, autologin might be undesirable, as scrolling through the list of users might login a selected user when it is undesired.
For this reason, having this functionality as a user-configurable setting makes sense.