-
Notifications
You must be signed in to change notification settings - Fork 1
resolve issue #2 (초기 로깅 시스템) #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ohksj77
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
고생하셨습니다.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mask 추가 제가 놓쳤었는데 추가해주셔서 감사합니다.
logback 자체에 maskPattern 태그로 추가하는 방안도 혹시 고려해보셨는지 궁금합니다. ref
지금 방식은 유지보수 측면에서 좋을지 고민입니다.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
좋은 생각인 거 같습니다. 확장성, 안정성 면에서 불안한 설계라고 생각이 들어 수정해서 리뷰 받겠습니다
ohksj77
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
고생하셨습니다.
수정 이유
추가/수정한 기능
로깅 결과 화면

특이사항
check list