-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to Ratatui #42
Conversation
Ratatui is a replacement for tui-rs that is actively maintained. See https://ratatui.rs/ for more info.
anyhow = "1.0" | ||
clap = { version = "4.2", features = ["derive"] } | ||
tempfile = "3.5" | ||
regex = "1.8" | ||
csv-sniffer = "0.3.1" | ||
|
||
[target.'cfg(windows)'.dependencies] | ||
crossterm = "0.25" | ||
crossterm = "0.27.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible keep this pinned at 0.25 for windows? This is due to an on-going issue in crossterm. More info: #30
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in 3ce170a
Usually apps can filter to only include key_event.kind == Press
to workaround this.
Is there a need to handle release events in this app? I didn't see anything obvious.
See ratatui/ratatui#347 for more info.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! I think this should work. Thanks for the fix.
Thank you @joshka! |
Crossterm 0.26+ reports key release events on windows, which results in the application seeing multiple events for a single key press. See ratatui/ratatui#347 for more info. Fixes YS-L#30
Not a problem. I've added this to the app showcase at https://ratatui.rs/showcase/apps/#csvlens |
@joshka That's awesome! Thanks for adding csvlens to the page. |
Ratatui is a replacement for tui-rs that is actively maintained.
See https://ratatui.rs/ for more info.