Warn if Metamod is detected. Auto disable it for cstrike.

[khanghugo]

Closes #501

"Warn" in here means exiting the game right away. I am not sure how to do it more elegantly.

[khanghugo]

Hmmm, it doesn't work on Windows. I keep getting error.

String manipulation in C++ is fairly arcane for me.

[SmileyAG]

Hmmm, it doesn't work on Windows. I keep getting error.

String manipulation in C++ is fairly arcane for me.

Well, the crucial issue with this code is actually not how you did the string manipulation, but how you declared the functions

You can only use __fastcall if you declare a member functions for Windows (e.g. CBasePlayer::TakeDamage)
In all other majority of cases, __cdecl will be your choice

Also, when you use __fastcall, you will need to specify int edx as the second parameter
edx doesn't seem to be used, so you can return any value to it (e.g. 0) in case you need to call that function

Examples:

HOOK_DECL(void, __cdecl, PM_PreventMegaBunnyJumping) // Windows, Linux

typedef void(__fastcall *_CBasePlayer__GiveNamedItem)(void *thisptr, int edx, const char *pszName); // Windows
_CBasePlayer__GiveNamedItem ORIG_CBasePlayer__GiveNamedItem;
typedef void(__cdecl *_CBasePlayer__GiveNamedItem_Linux)(void *thisptr, const char *pszName); // Linux
_CBasePlayer__GiveNamedItem_Linux ORIG_CBasePlayer__GiveNamedItem_Linux;

#ifdef _WIN32
ORIG_CBasePlayer__GiveNamedItem(classPtr, 0, HwDLL::GetInstance().GetString(iszItem));
#else
ORIG_CBasePlayer__GiveNamedItem_Linux(classPtr, HwDLL::GetInstance().GetString(iszItem));
#endif

[SmileyAG]

I also made a pull request with the necessary changes to that branch: khanghugo#4

[khanghugo]

Thanks. Looking good.

[khanghugo]

Eh, I wouldn't know really. @SmileyAG can explain that.

[SmileyAG]

Made appropriate changes from reviews.

And I handled most of edge cases for that request, but let know if I missed something more, he-he.

[YaLTeR]

Just to be sure @khanghugo could you test this still works on Linux?

[khanghugo]

Works for me.

[YaLTeR]

Thanks