systemd: move toplevel to separate scopes #795
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YaLTeR
reviewed
Nov 10, 2024
Cargo.toml
Outdated
| @@ -86,6 +86,7 @@ wayland-backend = "0.3.7" | |||
| wayland-scanner = "0.31.5" | |||
| xcursor = "0.3.8" | |||
| zbus = { version = "~3.15.2", optional = true } | |||
| zvariant = { version = "~3.15.2", optional = true } | |||
There was a problem hiding this comment.
It's exported under zbus::zvariant::
| } | ||
| } | ||
|
|
||
| let _ = write!(slice_name, ".slice"); |
There was a problem hiding this comment.
Why a slice and not a scope btw? All apps are in app.slice, and I only have the few pre-created slices on my system.
└─ systemctl --user | grep .slice
-.slice
app.slice
background.slice
session.slice
user.slice
There was a problem hiding this comment.
It should be both, the scope is named like app-niri-<app_id>-{pid}.scope and the slice is named app-niri-<app_id>.slice. This allows to override limits per app_id
cmeissl
force-pushed
the
feature/toplevel_scopes
branch
from
2babba6 to
9944957
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
niricreates a separate scope per spawn action matching the name of the executable.So for example launching the non flatpak version of
firefoxthroughfuzzelwill result in this firefox instanceto run under a scope name
app-niri-fuzzel-<PID>.scope.This can be problematic in combination with
xdg-portal, which will use the scope name as a fallback for thenon accessible app id.
To solve this, this PR tries to mimic what
systemd-swaydoes, moving toplevels to systemd scopes matching their app id.In addition to moving the process it also add slices like
systemd-swayoffers. This allows to override resourcelimits per app id slice.
The code is more a PoC and needs a major cleanup. The worst part is finding out all child pids that should also be moved to the new scope.