Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Migrate library and demo to androidx library + code cleanup #15

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

RofaeilAshaiaa
Copy link

@RofaeilAshaiaa RofaeilAshaiaa commented Jun 14, 2020

  • Migrated library module and demo module to use androidx and refactor
    the existing layouts and classes to use androidx.

  • Pumped compileSdkVersion and targetSdkVersion to 29, buildToolsVersion
    to 29.0.3.

  • Pumped gradle-wrapper to 6.4.1, gradle plugin to 4.0.0 and fabric
    plugin to 1.28.0 + adding the org.gradle.parallel=true property for
    faster build time.

  • Removed the butterknife dependency from demo module because it's now
    deprecated and causes runtime crashes without any obvious reasons and
    replaced the current code with a simple call to findViewById().

  • Returned PixelFormat.UNKNOWN from getOpacity() instead of 0, the raw
    value of this constant to avoid the error warning in android studio.

  • Removed *.iml files from the project to avoid project configurations
    issues on different computers when opening the project (which they
    should have been ignored in .gitignore file in the first place).

  • Removed Timber library from the library module because:

    1. it's causing crash on android 7.1 with this crash stacktrace
      java.lang.NoClassDefFoundError: Failed resolution of: Timber/log/Timber.
    2. the library should not include a logging library dependency in order
      to be a light weight library with minimum size effect on the app size
      that include it as possible.

Rofaeil Ashaiaa added 2 commits June 14, 2020 23:30
* Migrated library module and demo module to use androidx and refactor
 the existing layouts and classes to use androidx.

* Pumped compileSdkVersion and targetSdkVersion to 29, buildToolsVersion
 to 29.0.3.

 * Pumped gradle-wrapper to 6.4.1, gradle plugin to 4.0.0 and fabric
 plugin to 1.28.0 + adding the  org.gradle.parallel=true property for
 faster build time.

 * Removed the butterknife dependency from demo module because it's now
  deprecated and causes runtime crashes without any obvious reasons and
  replaced the current code with a simple call to findViewById().

 * Returned PixelFormat.UNKNOWN from getOpacity() instead of 0, the raw
 value of this constant to avoid the error warning in android studio.

 * Removed *.iml files from project to avoid project configurations
 issues on different computers when opening the project (which they
 should have been ignored in .gitignore file in the first place).
Removed Timber library from the library module because:
1. it's causing crash on android 7.1 with this crash stacktrace
java.lang.NoClassDefFoundError: Failed resolution of: Timber/log/Timber.
2. the library should not include a logging library dependency in order
to be a light weight library with minimum size effect on the app size
that include it as possible.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant