minor mod: Using empty (U+0020) instead of brailEmpty #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
icedream
added a commit
to icedream/customizepkg-config
that referenced
this pull request
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been using logo-ls for a while and in some cases white-spaces between icons and file names were rendered as follows.
I checked out the implementation and noticed that the
U+2800Braille pattern has been used since commit 1a227b5 as a space character, except for when the-iflag is risen. However, I found out thatU+2800does not act as a proper space in the Unicode standard, according to this unicode-explorer page.I replaced
U+2800withU+0020, the standard space character. Then, the output was properly rendered on every terminal.I hope this PR might be helpful and thank you for making logo-ls!