Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch packaging to hatch #37

Merged
merged 1 commit into from
Nov 22, 2023
Merged

Conversation

akx
Copy link
Contributor

@akx akx commented Nov 21, 2023

setup.py based packaging is legacy; using a PEP 517 build system is nicer and more modern, and hatch in particular is nice.

For one, the __version__ in miditoolkit/ and in the package metadata will no longer ever be out of sync, and you can also use hatch version patch (or minor or major) to conveniently bump it ✨

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7c8d7cc) 58.34% compared to head (e815fb5) 58.64%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #37      +/-   ##
==========================================
+ Coverage   58.34%   58.64%   +0.29%     
==========================================
  Files          12       11       -1     
  Lines         785      781       -4     
==========================================
  Hits          458      458              
+ Misses        327      323       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@akx akx marked this pull request as ready for review November 21, 2023 16:55
Copy link
Collaborator

@Natooz Natooz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just learned about hatchling, I am all for it!
I just have a concern on its use in the test workflow, but I'm maybe missing something

.github/workflows/pytest.yml Show resolved Hide resolved
@Natooz Natooz merged commit 8dcae6d into YatingMusic:master Nov 22, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants