Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More ruff linting #40

Merged
merged 6 commits into from
Nov 21, 2023
Merged

More ruff linting #40

merged 6 commits into from
Nov 21, 2023

Conversation

akx
Copy link
Contributor

@akx akx commented Nov 21, 2023

No description provided.

@codecov-commenter
Copy link

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (38cfa38) 58.34% compared to head (9ac52ea) 58.58%.

Files Patch % Lines
miditoolkit/midi/containers.py 20.00% 4 Missing ⚠️
miditoolkit/midi/parser.py 83.33% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #40      +/-   ##
==========================================
+ Coverage   58.34%   58.58%   +0.24%     
==========================================
  Files          12       12              
  Lines         785      780       -5     
==========================================
- Hits          458      457       -1     
+ Misses        327      323       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@Natooz Natooz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks greats thank you!
Some old commented code (removed here) was left just in case, but it shouldn't be needed really 👍

@Natooz Natooz merged commit ad3cc01 into YatingMusic:master Nov 21, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants