More idiomatic py.testing #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akx
force-pushed
the
more-idiomatic-pytesting
branch
from
3659608 to
956e41c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #41 +/- ##
==========================================
- Coverage 58.89% 58.83% -0.07%
==========================================
Files 11 12 +1
Lines 776 770 -6
==========================================
- Hits 457 453 -4
+ Misses 319 317 -2 ☔ View full report in Codecov by Sentry. |
akx
force-pushed
the
more-idiomatic-pytesting
branch
from
956e41c to
440d6b4
Compare
Natooz
approved these changes
Nov 21, 2023
There was a problem hiding this comment.
Thank you this is great!
Just waiting for your take on the comment before merging
As a non-software engineer (not day-to-day), I tried to follow the best practices when programming, to get good code quality. Now today I, thanks to you, I learned a ton of things and feel like I only did half of my job 😄
The CI is at a next level now!
akx
force-pushed
the
more-idiomatic-pytesting
branch
from
440d6b4 to
3168cc9
Compare
This comment was marked as outdated.
This comment was marked as outdated.
akx
force-pushed
the
more-idiomatic-pytesting
branch
from
dfbe595 to
04be95c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the testing configuration a little more idiomatic by using
pytest.mark.parametrizeso each test file gets run as a separate test case.