Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes remove_invalid_notes (renamed remove_notes_with_no_duration) + minor improvements #42

Merged
merged 5 commits into from
Nov 22, 2023

Conversation

Natooz
Copy link
Collaborator

@Natooz Natooz commented Nov 22, 2023

Fixes #39 + tests for the new method + brings minor improvements and updates (docstring, type hints, actions versions)
@akx

@Natooz Natooz added bug Something isn't working enhancement New feature or request labels Nov 22, 2023
miditoolkit/midi/containers.py Outdated Show resolved Hide resolved
miditoolkit/midi/containers.py Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Nov 22, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (c81dfe2) 58.83% compared to head (017d97f) 61.49%.

Files Patch % Lines
miditoolkit/midi/containers.py 75.00% 3 Missing ⚠️
miditoolkit/midi/parser.py 91.66% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #42      +/-   ##
==========================================
+ Coverage   58.83%   61.49%   +2.66%     
==========================================
  Files          12       13       +1     
  Lines         770      787      +17     
==========================================
+ Hits          453      484      +31     
+ Misses        317      303      -14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Co-authored-by: Aarni Koskela <akx@iki.fi>
@Natooz

This comment was marked as outdated.

@Natooz Natooz merged commit 3b0374f into YatingMusic:master Nov 22, 2023
17 checks passed
@Natooz Natooz deleted the fix-remove-note-no-duration branch November 22, 2023 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove_invalid_notes never removes anything unless verbose=False
3 participants