Fix MRO errors for TimeoutError under py311 #499
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
In py3.11,
concurrent.futures.TimeoutError
is aliased toTimeoutError
. This is a problem forbravado.http_future._raise_error
which constructs a dynamic error to combine the Bravado specific error with the original error. WithTimeoutError
andBravadoTimeoutError
, this will now throw an MRO error:This issue occurs with bravado-asyncio which explicitly throws
concurrent.futures.TimeoutError
.Solution
_raise_error
was created for python2 to ensure the original exception was not lost. With python 3, we can directly throwBravadoTimeoutError
without losing the original exception.Checking for the specific case where the caught exception is
TimeoutError
, we will raiseBravadoTimeoutError
TODO: Drop py2. This test will fail under py2 because
TimeoutError
doesn't exist until py33.Validation
bravady-asyncio has tests that will fail under py311:
tests/integration/bravado_integration_test.py::TestServerBravadoAsyncioClient
. This PR will make those tests pass.TODO: Write similar tests in this repo.