Add riscv64 support #305
Add riscv64 support #305
Conversation
|
@chriskuehl given some of the commits are not entirely related to |
luhenry
force-pushed
the
riscv64
branch
4 times, most recently
from
228e1d3 to
a80e397
Compare
Buster is EOL since 2022-09-10, and the LTS is also EOL since 2024-06-30. It's not available anymore in http://ftp.debian.org/debian/dists/ It's also safe to remove python3-distutils, since python3-setuptools depends on it. And given it's deprecated since Python 3.10, the package has been removed in later Debian versions (bookworm, trixie).
luhenry
force-pushed
the
riscv64
branch
4 times, most recently
from
a956ad4 to
82eae7e
Compare
It is based on Debian Trixie which is the first stable release to support riscv64.
Per [1], pre-commit/mirrors-autopep8 is deprecated in favor of https://github.com/hhatto/autopep8 [1] https://github.com/pre-commit/mirrors-autopep8?tab=readme-ov-file#deprecated
`ubuntu-20.04` isn't available anymore. It's safe to use `ubuntu-latest` since all the build steps are executed inside a container anyway so the dependency versions are controlled this way
Store it in the artifacts for future bookkeeping.
Version pytest-timeout<2.0.0 still depends on distutils which doesn't exist in debian bookworm anymore.
|
Full successful run on CI at https://github.com/luhenry/dumb-init/actions/runs/19029374564 |
|
Hi @chriskuehl 👋 I'm on the GitLab Runner team. Merging this |
|
unfortunately neither Chris nor I work at yelp any more so it might be unmaintained |
|
@kentwills You appear to still be at Yelp. Are you able to give this MR some love? |
|
tbf I don't think you actually need this merged here to use dumb-init on trixie: https://packages.debian.org/trixie/dumb-init and I don't think this PR should be merged as is -- it should be split into the separate individual patches such that it can be properly reviewed |
That's a good point. I'll take that back to the Gitlab Runner team and see what they want to do. It's also available in the Ubuntu and Alpine package managers.
Happy to do so regardless of what Gitlab wants to do (distro package manager or download releases), just to leave it better than how I found it :) |
3 participants
This PR adds support for RISC-V following the recent release of Debian Trixie on riscv64 as a stable target [1]. This also unblocks packaging and distributing Gitlab Runners on riscv64.
[1] https://www.debian.org/releases/trixie/