Delete more Mesos code #4088
Delete more Mesos code #4088
Conversation
…ted mesos anyway)
| self.get_deploy_group() is None | ||
| and self.get_executor() in MESOS_EXECUTOR_NAMES | ||
| ): | ||
| if self.get_deploy_group() is None and self.get_executor() != "ssh": |
There was a problem hiding this comment.
I tweaked this manually. This will make this check stricter -- anything with executor: spark will now have this check.
paasta_tools/cli/cmds/local_run.py
Outdated
| return (False, "%s (timeout %d seconds)" % (os.strerror(result), timeout)) | ||
|
|
||
|
|
||
| def execute_in_container(docker_client, container_id, command, timeout): |
There was a problem hiding this comment.
do we need to port any of the other logic that used to be in the paasta_execute_docker_command version?
(would also be nice to add some types to this since this isn't just a 1:1 move, but i won't block on that :p)
There was a problem hiding this comment.
silly robot, dunno why it rewrote this.
That said, the existing code seems to have a bug that I think I actually hit while using local-run the other day -- if something execs into the container before paasta does, it looks like it doesn't create an exec.
There was a problem hiding this comment.
Ok, I've put back the original function and fixed the bug. Now if the loop that searches for an existing exec doesn't find the one we're looking for, we'll create a new one.
…ppen if something besides paasta creates an exec before paasta does.
| host_ip=info.get("host_ip"), | ||
| git_sha=info.get("git_sha"), | ||
| config_sha=info.get("config_sha"), | ||
| mesos_container_id=None, |
There was a problem hiding this comment.
note: might be worth checking that the consumers of this will handle this field not existing at all anymore (pretty sure only splunk reads this and that it will gracefully handle things tho)
There was a problem hiding this comment.
looks like the savedsearch might do exactly the opposite of what we want if the mesos_container_id is missing. It's currently checking specifically for "null".
…e_docker_command.py to general_itests/steps/local_run_steps.py to fix itests
…e_docker_command.py to general_itests/steps/local_run_steps.py to fix itests
No description provided.