Make it possible to disable paging for check_autoscaler_max_instances (or any other specific alert generated by Paasta.) #4108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed to python 3.10 a while ago. This fixes 'make quick-test'.
…ml. This allows overriding sensu parameters for a specific check.
…ervice's monitoring section overrides the alert's defaults, not the other way around. PAASTA-18103
nemacysts
reviewed
Aug 26, 2025
| # monitoring.yaml | ||
| team: myteam # For most alerts, myteam will be notified. | ||
| check_overrides: | ||
| check_autoscaler_max_instances: |
There was a problem hiding this comment.
might be nice to have a central location with all the possible checks somewhere
Comment on lines
+93
to
+95
| max_instances_suggestion = "" | ||
| alert_threshold_suggestion = "" | ||
| disable_paging_suggestion = "" |
There was a problem hiding this comment.
it'd be nice to refactor things to not need to ""-init these, but it's not a big deal imo
| return team_data | ||
|
|
||
|
|
||
| def get_check_specific_overrides(overrides, check_name): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.