Validate smartstack.yaml in paasta validate
#4110
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We currently do this in an internal repo (`py-gitolite`), but I don't see why we don't just do this in `paasta validate` - especially since moving this check left means that folks are alerted to broken config earlier rather than when they attempt to integrate. The smartstack_schema.json in this repo was behind the one in py-gitolite, so I've gone ahead and made them match. The majority of the added code (outside the tests, which I had Claude Code regenerate for me) is more-or-less taken straight from py-gitolite with minimal changes. I ran `paasta validate` over all soaconfigs and verified that there are no new failures when run with this code.
nemacysts
force-pushed
the
luisp/validate-smartstack-paasta-validate
branch
from
2c73277 to
4a5f5c1
Compare
nemacysts
requested review from
EvanKrall,
jfongatyelp,
wilmer05,
cuza,
ajayOO8,
EmanElsaban,
ilkinmammadzada and
KaspariK
jfongatyelp
previously approved these changes
Sep 12, 2025
| "mode": { | ||
| "enum": [ | ||
| "http", | ||
| "http2", |
There was a problem hiding this comment.
Do we need http2 here twice? (line 127)
There was a problem hiding this comment.
huh, how did that happen
nemacysts
commented
Sep 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently do this in an internal repo (
py-gitolite), but I don't see why we don't just do this inpaasta validate- especially since moving this check left means that folks are alerted to broken config earlier rather than when they attempt to integrate.The smartstack_schema.json in this repo was behind the one in py-gitolite, so I've gone ahead and made them match.
The majority of the added code (outside the tests, which I had Claude Code regenerate for me) is more-or-less taken straight from py-gitolite with minimal changes.
I ran
paasta validateover all soaconfigs and verified that there are no new failures when run with this code.