Draft of tron support in remote-run - proof of concept #4114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piax93
reviewed
Sep 9, 2025
Comment on lines
156
to
164
| try: | ||
| # Load the service deployment settings | ||
| deployment_config = load_eks_or_adhoc_deployment_config( | ||
| service, instance, cluster, is_toolbox, user | ||
| ) | ||
| except: | ||
| # tron | ||
| tron = True | ||
| deployment_config = load_tron_config(service, instance, cluster) |
There was a problem hiding this comment.
Let's abstract this to a function too, so it a bit cleaner
deployment_config, is_tron = load_any_deployment_config(...)| ) | ||
| return projected_volumes if projected_volumes else None | ||
|
|
||
| def get_kubernetes_service_account_name(self) -> Optional[str]: |
There was a problem hiding this comment.
This is definitely a whole lot of repetition, but there's probably no other way for it without some huge refactor, so as long as CI is fine with it, I'm fine.
nemacysts
reviewed
Sep 26, 2025
Comment on lines
+172
to
+174
| else: | ||
| # Tron dicts use "command" instead of "cmd" and expects an array | ||
| deployment_config.config_dict["command"] = ["/usr/bin/sleep", str(max_duration)] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is unfinished, seeking early feedback
Experiment to see what it would take to use Tron jobs with remote-run. To implement this fully in paasta, I updated TronActionConfig with functions get format_as_kubernetes_job working like it does for long running jobs. These were mostly copied from kubernetes_tools with modifications and removals of things that seem unnecessary in this context. If we go with this approach, there's lots of opportunity for refactoring.
There's several TODOs of stuff that I skipped for now like volumes.
This works, but I want feedback before cleaning it up. The main alternative to this is to import task_processing/tron and try to make use of the relevant code there which does something similar.