Open
Conversation
This fixes the variable name mismatch in the FmodStudioAdvancedSettings constructor and fmod_studio_system_set_advanced_settings function. The FmodStudioAdvancedSettings constructor has idle_sampledata_pool_size, and fmod_studio_system_set_advanced_settings uses idle_sample_data_pool_size. This adds an underscore to the property in the constructor.
Collaborator
|
The name of the variable cannot be changed there cus the C++ side creates the object with a variable name called "idle_sampledata_pool_size" so if you change the name there that variable will always be undefined when returned from the C++ layer. Changing this will also imply breaking other users projects that are reading that variable name... If you want the same name to be used the best alternative is to change the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the variable name mismatch in the
FmodStudioAdvancedSettingsconstructor andfmod_studio_system_set_advanced_settingsfunction. TheFmodStudioAdvancedSettingsconstructor hasidle_sampledata_pool_size, andfmod_studio_system_set_advanced_settingsusesidle_sample_data_pool_size. This adds an underscore to the property in the constructor.