Skip to content

Fixed a variable name mismatch#43

Open
Sandveech wants to merge 1 commit intoYoYoGames:mainfrom
Sandveech:main
Open

Fixed a variable name mismatch#43
Sandveech wants to merge 1 commit intoYoYoGames:mainfrom
Sandveech:main

Conversation

@Sandveech
Copy link
Copy Markdown

This fixes the variable name mismatch in the FmodStudioAdvancedSettings constructor and fmod_studio_system_set_advanced_settings function. The FmodStudioAdvancedSettings constructor has idle_sampledata_pool_size, and fmod_studio_system_set_advanced_settings uses idle_sample_data_pool_size. This adds an underscore to the property in the constructor.

This fixes the variable name mismatch in the FmodStudioAdvancedSettings constructor and fmod_studio_system_set_advanced_settings function. The FmodStudioAdvancedSettings constructor has idle_sampledata_pool_size, and fmod_studio_system_set_advanced_settings uses idle_sample_data_pool_size. This adds an underscore to the property in the constructor.
@DiasFranciscoA
Copy link
Copy Markdown
Collaborator

DiasFranciscoA commented Mar 6, 2026

The name of the variable cannot be changed there cus the C++ side creates the object with a variable name called "idle_sampledata_pool_size" so if you change the name there that variable will always be undefined when returned from the C++ layer. Changing this will also imply breaking other users projects that are reading that variable name... If you want the same name to be used the best alternative is to change the fmod_studio_system_set_advanced_settings parameter to match the _idle_sampledata_pool_size instead, and not the other way around.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

3 participants