Repository navigation
ci: lean Linux-only CI, lint and typecheck move to the pre-push hook - #206
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #205
Summary
CI now runs only test and build on Linux. Biome and both typechecks run in the husky pre-push hook. Actions are pinned to SHAs. CI runs on PRs and on push to main, and the main run saves the pnpm cache.
Moved
pnpm run check:cinow in.husky/pre-pushpnpm run typecheckandpnpm run typecheck:mcp-appsnow in the hookreport-failure(it only fired on push to main, which CI no longer runs) and the four reusable workflow filesapi-sync.yml(manual, files issues) was not a check job; only its actions were pinnedHook proof
Probe commit with a type error was blocked:
src/index.ts(150,14): error TS2322: Type 'string' is not assignable to type 'number'.thenhusky - pre-push script failed (code 2). The probe was dropped; this branch pushed through the hook.Timing
Test plan
Confidence 8/10
Update: CI also runs on main
Public repo, so minutes are free: checks now run on
pull_request,pushto main (paths-ignore**/*.md) andworkflow_dispatch. Cancel only applies to pull requests. The main run saves the pnpm cache, sowarm-cache.ymlwas removed. Push runs the full suite (sinceis empty). The main-failure issue workflow (report-failure) is restored, with a timeout and pinned SHAs.