Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quote CMAKE_BUILD_TYPE in CMakeLists.txt to allow it being unset. #16

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

janbraun
Copy link

@janbraun janbraun commented Jul 3, 2020

Right now, cmake will fail when called without defining CMAKE_BUILD_TYPE with

CMake Error at CMakeLists.txt:15 (if):
  if given arguments:

    "STREQUAL" "Debug"

  Unknown arguments specified

Quoting the variable will make cmake pass. This is super-trivial and maybe not what you want.
Then I would suggest to set a default build type instead, or ignoring this pull request. :-)

@Yours3lf
Copy link
Owner

Thank you for noticing this! Kind of on the fence about this, the error will probably make people actually read build.md :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants