Fixed a defect in the Result.IsValid logic

Yuck · Jan 21, 2022 · b930dbb · b930dbb
1 parent 492af94
commit b930dbb
Show file tree

Hide file tree

Showing 6 changed files with 48 additions and 8 deletions.
diff --git a/src/YuckQi.Domain.Services/YuckQi.Domain.Services.csproj b/src/YuckQi.Domain.Services/YuckQi.Domain.Services.csproj
@@ -4,7 +4,7 @@
     <TargetFramework>netstandard2.0</TargetFramework>
     <GeneratePackageOnBuild>true</GeneratePackageOnBuild>
     <Authors>Kevin J Lambert</Authors>
-    <Version>1.1.1</Version>
+    <Version>1.2.0</Version>
     <PackageLicenseFile>LICENSE</PackageLicenseFile>
     <Description>A .NET library for bootstrapping a domain services project.</Description>
   </PropertyGroup>

diff --git a/src/YuckQi.Domain.Validation/Result.cs b/src/YuckQi.Domain.Validation/Result.cs
@@ -10,7 +10,7 @@ public class Result
 
         public IReadOnlyCollection<ResultDetail> Detail { get; }
 
-        public Boolean IsValid => Detail != null && Detail.Any(t => t.Type == ResultType.Error);
+        public Boolean IsValid => Detail.All(t => t.Type != ResultType.Error);
 
         #endregion
 

diff --git a/src/YuckQi.Domain.Validation/YuckQi.Domain.Validation.csproj b/src/YuckQi.Domain.Validation/YuckQi.Domain.Validation.csproj
@@ -4,7 +4,7 @@
     <TargetFramework>netstandard2.0</TargetFramework>
     <GeneratePackageOnBuild>true</GeneratePackageOnBuild>
     <Authors>Kevin J Lambert</Authors>
-    <Version>1.1.1</Version>
+    <Version>1.2.0</Version>
     <PackageLicenseFile>LICENSE</PackageLicenseFile>
     <Description>A .NET library providing domain validation fundamentals.</Description>
   </PropertyGroup>

diff --git a/src/YuckQi.Domain/YuckQi.Domain.csproj b/src/YuckQi.Domain/YuckQi.Domain.csproj
@@ -4,7 +4,7 @@
     <TargetFramework>netstandard2.0</TargetFramework>
     <GeneratePackageOnBuild>true</GeneratePackageOnBuild>
     <Authors>Kevin J Lambert</Authors>
-    <Version>1.1.1</Version>
+    <Version>1.2.0</Version>
     <PackageLicenseFile>LICENSE</PackageLicenseFile>
     <Description>A .NET library for bootstrapping a domain model project.</Description>
   </PropertyGroup>

diff --git a/test/YuckQi.Domain.Validation.UnitTests/ResultCodeTests.cs b/test/YuckQi.Domain.Validation.UnitTests/ResultCodeTests.cs
@@ -10,10 +10,10 @@ public void Setup() { }
     [Test]
     public void ResultCode_WithSameCode_HasSameHashCode()
     {
-        var a = new ResultCode("test");
-        var hashCodeA = a.GetHashCode();
-        var b = new ResultCode("test");
-        var hashCodeB = b.GetHashCode();
+        var resultCodeA = new ResultCode("test");
+        var hashCodeA = resultCodeA.GetHashCode();
+        var resultCodeB = new ResultCode("test");
+        var hashCodeB = resultCodeB.GetHashCode();
 
         Assert.AreEqual(hashCodeA, hashCodeB);
     }

diff --git a/test/YuckQi.Domain.Validation.UnitTests/ResultTests.cs b/test/YuckQi.Domain.Validation.UnitTests/ResultTests.cs
@@ -0,0 +1,40 @@
+using System;
+using System.Collections.Generic;
+using NUnit.Framework;
+
+namespace YuckQi.Domain.Validation.UnitTests;
+
+public class ResultTests
+{
+    [SetUp]
+    public void Setup() { }
+
+    [Test]
+    public void Result_WithErrors_IsNotValid()
+    {
+        var detail = new List<ResultDetail> { new(new ResultCode("test"), new ResultMessage("id")) };
+        var result = new Result<String>("test", detail);
+        var isValid = result.IsValid;
+
+        Assert.IsFalse(isValid);
+    }
+
+    [Test]
+    public void Result_WithNoDetail_IsValid()
+    {
+        var result = new Result<String>("test");
+        var isValid = result.IsValid;
+
+        Assert.IsTrue(isValid);
+    }
+
+    [Test]
+    public void Result_WithOnlyWarnings_IsValid()
+    {
+        var detail = new List<ResultDetail> { new(new ResultCode("test"), new ResultMessage("id"), type: ResultType.Warning) };
+        var result = new Result<String>("test", detail);
+        var isValid = result.IsValid;
+
+        Assert.IsTrue(isValid);
+    }
+}