Skip to content

fetch assets off main thread #783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NikKovIos merged 1 commit into from
Apr 22, 2025
Merged

fetch assets off main thread #783

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 17 additions & 7 deletions Source/Pages/Gallery/YPLibraryVC.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,15 +228,25 @@ internal final class YPLibraryVC: UIViewController, YPPermissionCheckable {
}
}

func refreshMediaRequest() {
let options = buildPHFetchOptions()
private func refreshMediaRequest() {

// calls to fetchAssets can take a while for large libraries and we don't want to block the main thread
DispatchQueue.global().async {
let options = self.buildPHFetchOptions()

if let collection = mediaManager.collection {
mediaManager.fetchResult = PHAsset.fetchAssets(in: collection, options: options)
} else {
mediaManager.fetchResult = PHAsset.fetchAssets(with: options)
if let collection = self.mediaManager.collection {
self.mediaManager.fetchResult = PHAsset.fetchAssets(in: collection, options: options)
} else {
self.mediaManager.fetchResult = PHAsset.fetchAssets(with: options)
}

DispatchQueue.main.async {
self.refreshMediaRequestAfterFetch()
}
}

}

private func refreshMediaRequestAfterFetch() {
if mediaManager.hasResultItems,
let firstAsset = mediaManager.getAsset(at: 0) {
changeAsset(firstAsset)
Expand Down