Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create docker file and docker build CI #24

Merged
merged 32 commits into from
Apr 29, 2022
Merged

Create docker file and docker build CI #24

merged 32 commits into from
Apr 29, 2022

Conversation

henryclw
Copy link
Contributor

Refer to #18 (comment)

@vercel
Copy link

vercel bot commented Apr 27, 2022 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/yunyoujun/cook/4mgt7dJ7rEao7kS9hsakLMfXvLBv
✅ Preview: https://cook-git-fork-henryclw-main-yunyoujun.vercel.app

@netlify
Copy link

netlify bot commented Apr 27, 2022 •
edited
Loading

✅ Deploy Preview for cook-today ready!

Name Link
🔨 Latest commit fe8dacf
🔍 Latest deploy log https://app.netlify.com/sites/cook-today/deploys/626c2278566ab90009bc540e
😎 Deploy Preview https://deploy-preview-24--cook-today.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

YunYouJun
YunYouJun requested changes Apr 27, 2022
View reviewed changes
README.md Outdated Show resolved Hide resolved
henryclw added 11 commits April 27, 2022 14:21
@henryclw
Use official CI/CD of GitHub docker action
88bf882 
https://docs.docker.com/language/nodejs/configure-ci-cd/
@henryclw
Fix typo in docker-image.yml
e02260e
@henryclw
Add last line in docker-image.yml
a684c3b
@henryclw
Update docker-image.yml, use docker/login-action@v1
f15e007
@henryclw
Revert "Update docker-image.yml, use docker/login-action@v1"
29e9ba5 
This reverts commit f15e007.
@henryclw
Let docker image tag be the same as the branch name
097b11c 
https://stackoverflow.com/questions/58033366/how-to-get-the-current-branch-within-github-actions
@henryclw
Let docker image tag be the same as the branch name, use branch name …
e2dfe2e 
…${GITHUB_REF#refs/heads/}
@henryclw
Use docker/metadata-action in docker-image.yml
cba3376 
https://github.com/docker/metadata-action
@henryclw
Fix image name in docker/metadata-action in docker-image.yml
f45015f
@henryclw
Use master branch of docker/metadata-action in docker-image.yml
b7521cb
@henryclw
Merge pull request #3 from henryclw/dev-docker
4f18f87 
Docker official CI/CD
@vercel
Copy link

vercel bot commented Apr 28, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
cook ✅ Ready (Inspect) Visit Preview Apr 29, 2022 at 5:38PM (UTC)

@henryclw
Copy link
Contributor Author

I've update the .github/workflows/docker-image.yml file, please add these two secrets to this repo accordingly:

  • DOCKER_HUB_USERNAME
  • DOCKER_HUB_ACCESS_TOKEN

Then create the cook repo under your docker hub account.
Once done, it should be able to auto build and push images to docker hub.

YunYouJun
YunYouJun reviewed Apr 28, 2022
View reviewed changes
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@YunYouJun
Copy link
Owner

I update some details in 6b0901b.

Can you check it? I'll merge it if it's ok.

@henryclw
Copy link
Contributor Author

henryclw commented Apr 29, 2022 •
edited by YunYouJun
Loading

I update some details in 6b0901b.

Can you check it? I'll merge it if it's ok.

Seems good to me. The next things you may want to do are:

  • Create the corresponding secrets under this repo
  • Merge the pull request
  • Check the actions, are they working as expected
  • Check your Docker Hub account, are the newly pushed images as expected
  • Pull one of the image and try to run it locally

@YunYouJun YunYouJun merged commit 5015653 into YunYouJun:main Apr 29, 2022
@YunYouJun
Copy link
Owner

Thanks for your contribution.

@YunYouJun YunYouJun mentioned this pull request Apr 29, 2022
Open
@henryclw
Copy link
Contributor Author

Thanks for your contribution.

You're welcome. Good night and sleep tight.

But I've just found a minor problem with the latest tag #26 , if you have spare time tomorrow you might want to check this out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YunYouJun YunYouJun YunYouJun requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@henryclw @YunYouJun