Skip to content

fix linter#17

Closed
ericgaspar wants to merge 1 commit intotestingfrom
fix-linter
Closed

fix linter#17
ericgaspar wants to merge 1 commit intotestingfrom
fix-linter

Conversation

@ericgaspar
Copy link
Copy Markdown
Member

Problem

  • Description of why you made this PR

Solution

  • And how do you fix that problem

PR Status

  • Code finished and ready to be reviewed/tested
  • The fix/enhancement were manually tested (if applicable)

Automatic tests

Automatic tests can be triggered on https://ci-apps-dev.yunohost.org/ after creating the PR, by commenting "!testme", "!gogogadgetoci" or "By the power of systemd, I invoke The Great App CI to test this Pull Request!". (N.B. : for this to work you need to be a member of the Yunohost-Apps organization)

@ericgaspar
Copy link
Copy Markdown
Member Author

!tastemetitus

@yunohost-bot
Copy link
Copy Markdown
Contributor

That feels weird, but I'll allow it. 🤖
Test Badge

Comment thread manifest.json
"fr": "Application web de gestion des bases de données PostgreSQL"
},
"version": "4-5.7~ynh1",
"version": "5.7~ynh1",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, the real version is 4-5.7 not 5.7 so we can't just remove this. The main version of pgadmin is "pgadmin 4"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a issue about this problem here: YunoHost/package_linter#102

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fair enough.

@ericgaspar ericgaspar closed this Feb 7, 2022
@ericgaspar ericgaspar deleted the fix-linter branch February 7, 2022 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants