-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade database scheme #133
base: testing
Are you sure you want to change the base?
Conversation
Pre-2018 installation had a bad database scheme. This should fix it partly, and allow them to upgrade to wallabag 2.4.x. See : YunoHost-Apps#125
!testme |
@lapineige can you !testme please :p? I tested on my server, it upgrades to 2.4.3 like a charm. |
!testme |
Oh, I didn't know there were some restricted right for that CI thing…
🎉 |
Meh, still failing in the CI. It all depends on which migrations were already applied I guess. |
Thanks anyway for all your work, at least it's documented somewhere and maybe usable to migrate without doing all the SQL stuff by oneself (but instead one can use this branch). I'll keep it open for a while in case someone want to help 🙂 |
OK... So now I understand why my wallabag, installed in 2017, was failing upgrades... EDIT : It worked ! |
Great ! |
Is it OK for you to replace this PR with #129 ? Although it looks like the sql code is not identical… |
I don't know. It was here to help in some very special case for some upgrade/migration purpose. I guess it's not really used anymore, and I wouldn't bother merging this until someone actually complains about it not being compatible. |
Problem
Pre-2018 installation had a bad database scheme. This should fix it partly, and allow them to upgrade to wallabag 2.4.x.
See : #125
Solution
PR Status
Automatic tests
Automatic tests can be triggered on https://ci-apps-dev.yunohost.org/ after creating the PR, by commenting "!testme", "!gogogadgetoci" or "By the power of systemd, I invoke The Great App CI to test this Pull Request!". (N.B. : for this to work you need to be a member of the Yunohost-Apps organization)