Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade database scheme #133

Draft
wants to merge 1 commit into
base: testing
Choose a base branch
from

Conversation

nicofrand
Copy link

Problem

Pre-2018 installation had a bad database scheme. This should fix it partly, and allow them to upgrade to wallabag 2.4.x.
See : #125

Solution

  • Remove old foreign keys and create new ones

PR Status

  • Code finished and ready to be reviewed/tested
  • The fix/enhancement were manually tested (if applicable)

Automatic tests

Automatic tests can be triggered on https://ci-apps-dev.yunohost.org/ after creating the PR, by commenting "!testme", "!gogogadgetoci" or "By the power of systemd, I invoke The Great App CI to test this Pull Request!". (N.B. : for this to work you need to be a member of the Yunohost-Apps organization)

Pre-2018 installation had a bad database scheme. This should fix it partly, and allow them to upgrade to wallabag 2.4.x.
See : YunoHost-Apps#125
@nicofrand nicofrand changed the base branch from master to testing March 30, 2022 12:51
@nicofrand
Copy link
Author

!testme

@nicofrand
Copy link
Author

@lapineige can you !testme please :p?

I tested on my server, it upgrades to 2.4.3 like a charm.

@lapineige
Copy link
Member

!testme

@yunohost-bot
Copy link
Contributor

🌻
Test Badge

@lapineige
Copy link
Member

@lapineige can you !testme please :p?

Oh, I didn't know there were some restricted right for that CI thing…

I tested on my server, it upgrades to 2.4.3 like a charm.

🎉

@nicofrand
Copy link
Author

Meh, still failing in the CI. It all depends on which migrations were already applied I guess.
I give up, if needed people can always use this branch to upgrade and then upgrade to any further version.

@lapineige
Copy link
Member

Thanks anyway for all your work, at least it's documented somewhere and maybe usable to migrate without doing all the SQL stuff by oneself (but instead one can use this branch).

I'll keep it open for a while in case someone want to help 🙂

@Limezy
Copy link

Limezy commented Aug 22, 2022

OK... So now I understand why my wallabag, installed in 2017, was failing upgrades...
Shall I start migrating my db using this PR, and then upgrade using the standard chanel ?

EDIT : It worked !

@lapineige
Copy link
Member

Great !

@Salamandar
Copy link
Member

Salamandar commented Mar 9, 2024

Is it OK for you to replace this PR with #129 ? Although it looks like the sql code is not identical…

@lapineige
Copy link
Member

I don't know. It was here to help in some very special case for some upgrade/migration purpose.
Nobody posted feedback on this for 2 years.

I guess it's not really used anymore, and I wouldn't bother merging this until someone actually complains about it not being compatible.
I'd keep it as a stale PR.

@Salamandar Salamandar added Archive Keept for eventual users and removed help wanted pending labels Mar 9, 2024
@Salamandar Salamandar marked this pull request as draft March 9, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Archive Keept for eventual users
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants